Open
Conversation
Farjaad
reviewed
Mar 2, 2026
| return properties | ||
|
|
||
|
|
||
| def deduplicate_properties_by_name(properties): |
Contributor
There was a problem hiding this comment.
should we de-dup by alias instead? that's what we do in the frontend of our app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom Properties are created on a per componentType basis. It's expected that custom properties with the same alias have the same schema. When converting tags to custom properties, it's assumed that componentTypes with the tags also have the required custom property defined.
This deduplicates the list of custom properties shown for the user to select from.